You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The other dependencies have a required dependency of core, since they cannot function without them. Core has an optional peer dep, since it can function without them, but should they be installed, they need to be within this version range and a dep of core
The other dependencies have a required dependency of core, since they cannot function without them. Core has an optional peer dep, since it can function without them, but should they be installed, they need to be within this version range and a dep of core
Right but I feel we are creating cyclically peerDeps core depends on their downstream [...]
It looks cyclic if you count peer edges, but it's an acyclic install graph, so this is an "intentional" semi-cycle (so-to-speak). core needs the peer declaration so pnpm resolves the optional packages into core's node_modules context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled, a fix for changesets